Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to Aptos Foundation AIP GitHub from Aptos Governance page #5899

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix link to Aptos Foundation AIP GitHub from Aptos Governance page #5899

merged 1 commit into from
Dec 16, 2022

Conversation

clay-aptos
Copy link
Contributor

Description

Test Plan

@clay-aptos clay-aptos requested a review from davidiw as a code owner December 16, 2022 19:50
@clay-aptos clay-aptos enabled auto-merge (squash) December 16, 2022 19:53
@clay-aptos clay-aptos merged commit 0ebd89d into main Dec 16, 2022
@clay-aptos clay-aptos deleted the clay-aptos-patch-2 branch December 16, 2022 19:55
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on e8c94f925f2ae1ae1640e3f0cb9746ce1f0dc3dc

performance benchmark with full nodes : 6107 TPS, 6503 ms latency, 10800 ms p99 latency,(!) expired 60 out of 2607800 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e8c94f925f2ae1ae1640e3f0cb9746ce1f0dc3dc

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e8c94f925f2ae1ae1640e3f0cb9746ce1f0dc3dc (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7366 TPS, 5269 ms latency, 7000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: e8c94f925f2ae1ae1640e3f0cb9746ce1f0dc3dc
compatibility::simple-validator-upgrade::single-validator-upgrade : 4418 TPS, 9448 ms latency, 12100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: e8c94f925f2ae1ae1640e3f0cb9746ce1f0dc3dc
compatibility::simple-validator-upgrade::half-validator-upgrade : 4424 TPS, 9358 ms latency, 13000 ms p99 latency,no expired txns
4. upgrading second batch to new version: e8c94f925f2ae1ae1640e3f0cb9746ce1f0dc3dc
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6552 TPS, 6019 ms latency, 9600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e8c94f925f2ae1ae1640e3f0cb9746ce1f0dc3dc passed
Test Ok

cathyaptos
cathyaptos reviewed Dec 21, 2022
View reviewed changes
Copy link

@cathyaptos cathyaptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! thanks for fixing

@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathyaptos cathyaptos cathyaptos left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@gregnazario gregnazario gregnazario approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@areshand areshand Awaiting requested review from areshand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clay-aptos @gregnazario @cathyaptos